From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 01/17] drm/i915: Move the irq wait queue initialisation into the ring init Date: Thu, 21 Apr 2011 15:26:50 -0700 Message-ID: <20110421152650.1165740d@jbarnes-desktop> References: <1303420712-6369-1-git-send-email-chris@chris-wilson.co.uk> <1303420712-6369-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.39.38]) by gabe.freedesktop.org (Postfix) with SMTP id 9613D9E759 for ; Thu, 21 Apr 2011 15:26:54 -0700 (PDT) In-Reply-To: <1303420712-6369-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 21 Apr 2011 22:18:16 +0100 Chris Wilson wrote: > Required so that we don't obliterate the queue if initialising the > rings after the global IRQ handler is installed. > > [Jesse, you recently looked at refactoring the IRQ installation > routines, does moving the initialisation of ring buffer data structures away > from that routine make sense in your grand scheme?] Yeah, this looks fine. It'll cause a trivial conflict with my split patch, but that's ok. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center