From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 05/10] drm/i915: Move the ACPI lid notifier away from LVDS to the generic panel Date: Fri, 22 Apr 2011 09:21:59 -0700 Message-ID: <20110422092159.1d274e02@jbarnes-desktop> References: <1303463958-17128-1-git-send-email-chris@chris-wilson.co.uk> <1303463958-17128-6-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com [66.147.249.253]) by gabe.freedesktop.org (Postfix) with SMTP id 172899E74B for ; Fri, 22 Apr 2011 09:22:03 -0700 (PDT) In-Reply-To: <1303463958-17128-6-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 22 Apr 2011 10:19:13 +0100 Chris Wilson wrote: > ... in preparation for enabling it from eDP as well. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_drv.h | 8 +++ > drivers/gpu/drm/i915/intel_lvds.c | 79 ++----------------------------- > drivers/gpu/drm/i915/intel_panel.c | 92 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 104 insertions(+), 75 deletions(-) Not sure if this one or 6/10 are needed. Originally we added lid status support to detect LVDS presence and to reset modes if the BIOS shut off planes/pipes at lid close time. But neither of those was every very pretty, and the presence check was a complete failure because every vendor has another, accurate way to provide lid status; ACPI was only ever a red herring for us poor Linux folks. But if you have some good use case and we can get some really really good test coverage, these patches look nice. -- Jesse Barnes, Intel Open Source Technology Center