From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 08/10] drm/i915/dp: If the panel has a fixed_mode, it can only be eDP Date: Fri, 22 Apr 2011 09:24:56 -0700 Message-ID: <20110422092456.56d1e91f@jbarnes-desktop> References: <1303463958-17128-1-git-send-email-chris@chris-wilson.co.uk> <1303463958-17128-9-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.39.38]) by gabe.freedesktop.org (Postfix) with SMTP id B193A9E74B for ; Fri, 22 Apr 2011 09:25:00 -0700 (PDT) In-Reply-To: <1303463958-17128-9-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 22 Apr 2011 10:19:16 +0100 Chris Wilson wrote: > ... and so we can simplify some conditionals. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/intel_dp.c | 17 +++++++---------- > 1 files changed, 7 insertions(+), 10 deletions(-) Only downside of this is that it makes the code a little less readable. The is_edp checks make it obvious that you're looking fro eDP, while looking at the fixed mode is more implicit. Maybe a new macro, is_panel() or something that does the check? -- Jesse Barnes, Intel Open Source Technology Center