Re: [PATCH 02/10] drm/i915/lvds: Introduce intel_lvds_connector

Chris Wilson
2011-04-22T18:07:43Z

On Fri, 22 Apr 2011 10:50:47 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> How about to save some eyestrain, using some macro helpers?
>
> struct intel_lvds_connector {
> struct intel_connector base;
> #define drm_base \
> base.base
> #define drm_dev \
> drm_base.dev
> #define drm_funcs \
> drm_base.funcs
> };
>
> Similarly with lvds_encoder, and intel_dp structures if you so desire.

I'm always a little wary about macros to hide details of the structure,
they make the relationships less discoverable.

Fortunately, by the end of the series most of the eye sores have gone.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre