Re: [PATCH 05/10] drm/i915: Move the ACPI lid notifier away from LVDS to the generic panel

Jesse Barnes
2011-04-22T16:22:03Z

On Fri, 22 Apr 2011 10:19:13 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> ... in preparation for enabling it from eDP as well.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/intel_drv.h | 8 +++
> drivers/gpu/drm/i915/intel_lvds.c | 79 ++-----------------------------
> drivers/gpu/drm/i915/intel_panel.c | 92 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 104 insertions(+), 75 deletions(-)

Not sure if this one or 6/10 are needed. Originally we added lid
status support to detect LVDS presence and to reset modes if the BIOS
shut off planes/pipes at lid close time.

But neither of those was every very pretty, and the presence check was
a complete failure because every vendor has another, accurate way to
provide lid status; ACPI was only ever a red herring for us poor Linux
folks.

But if you have some good use case and we can get some really really
good test coverage, these patches look nice.

--
Jesse Barnes, Intel Open Source Technology Center