From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: forcewake v5
Date: Mon, 25 Apr 2011 11:21:23 -0700
Message-ID: <20110425182123.GA2426@bwgnt.jf.intel.com>
References: <1303343599-18509-1-git-send-email-ben@bwidawsk.net>
	<1bdc18$ka879k@fmsmga002.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id C9D699E74B
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 25 Apr 2011 11:21:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1bdc18$ka879k@fmsmga002.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Apr 21, 2011 at 07:39:27AM +0100, Chris Wilson wrote:
> On Wed, 20 Apr 2011 16:53:14 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > 
> > Once you're done laughing that I got up to v5 (I think I skipped a v3,
> > and v1 was the IOCTls, so it's really more like a v3) for patches meant
> > to simply allow register reads and wites...
> > 
> > Back to struct_mutex since it turned out to be my mistake regarding the
> > IIR problem. The only issue in the interrupt handler was rps, which has
> > been moved to a workqueue.
> > 
> > Struct_mutex must be held to forcewake, or relinquish forcwake.
> 
> Ok, I got to the end. I feel really squeamish that our register read/write
> routines are getting seriously overcomplicated for interrupt work and
> would like a cut down version for IRQ context.
> 
> But other than that and some silly code that needs to be improved in light
> of your review, it's looking good.
> -Chris

To save starting a new thread, I'm uploading the fixes to this thread. I
will start a new thread if the fixes are accepted.

Ben