From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [3.0-rc3] i915: potentially stale ring data during resume Date: Sat, 18 Jun 2011 09:12:16 -0700 Message-ID: <20110618161215.GA8502@snipes.kumite> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 35E449E7CE for ; Sat, 18 Jun 2011 09:12:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel J Blueman Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Jun 18, 2011 at 02:48:29PM +0800, Daniel J Blueman wrote: > Hi Eric, Chris, > > There are quite a lot of callers of I915_READ/WRITE which aren't > holding the dev->struct_mutex lock across device suspend and resume > operations, to prevent the GT going to sleep early if two callers are > in the gen6_gt_force_wake_get->gen6_gt_force_wake_put critical region. > > I started cooking up a patch, but ran out of time. Please note the only register range that matters is 0-0x40000 (don't ask how we know that). Ben