From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked Date: Mon, 8 Aug 2011 13:01:28 -0700 Message-ID: <20110808130128.06654f54@jbarnes-desktop> References: <1312653248-3487-1-git-send-email-keithp@keithp.com> <1312653248-3487-3-git-send-email-keithp@keithp.com> <20110808093010.487c4559@jbarnes-desktop> <20110808114954.23b62dd3@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 08 Aug 2011 12:53:31 -0700 Keith Packard wrote: > On Mon, 8 Aug 2011 11:49:54 -0700, Jesse Barnes wrote: > > > Yep, it's safe and possible to do on pre-PCH as well. For panel > > fitting we do need to do an actual power cycle when going from > > non-native back to native iirc, but we can still leave them unlocked so > > we don't have to worry about the lock/unlock sequence everywhere. > > Hidden in the unlock patch was a call to intel_lvds_disable from > intel_lvds_prepare -- that *always* turns off the LVDS for mode > setting. Do we care enough about LVDS mode setting performance that we > should try leave the optimization in place that doesn't turn off the > backlight when switching between modes? We hate flicker right? But generally yes it's safer to just turn it off all the time. -- Jesse Barnes, Intel Open Source Technology Center