From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: limit PM related interrupt enable
 to those we handle
Date: Tue, 9 Aug 2011 10:11:40 -0700
Message-ID: <20110809101140.672ed005@jbarnes-desktop>
References: <1312907360-2469-1-git-send-email-jbarnes@virtuousgeek.org>
	<yun4o1q8qm9.fsf@aiko.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com
	[67.222.38.55])
	by gabe.freedesktop.org (Postfix) with SMTP id AD1469E8B8
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  9 Aug 2011 10:11:54 -0700 (PDT)
In-Reply-To: <yun4o1q8qm9.fsf@aiko.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 09 Aug 2011 10:02:54 -0700
Keith Packard <keithp@keithp.com> wrote:

> On Tue,  9 Aug 2011 09:29:20 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > -	I915_WRITE(GEN6_PMIMR, 0);
> > +	I915_WRITE(GEN6_PMIMR, ~GEN6_PM_DEFERRED_EVENTS);
> >  	spin_unlock_irq(&dev_priv->rps_lock);
> > -	/* enable all PM interrupts */
> > -	I915_WRITE(GEN6_PMINTRMSK, 0);
> > +	/* Enable only those we respond to in the deferred work handler */
> > +	I915_WRITE(GEN6_PMINTRMSK, GEN6_PMINTR_DEFERRED_EVENTS);
> 
> I think this is supposed to only enable the DEFERRED_EVENTS, right? In
> which case, I think you want to invert that (as 0 enables and 1 disables):
> 
>  +	I915_WRITE(GEN6_PMINTRMSK, ~GEN6_PMINTR_DEFERRED_EVENTS);
> 
> just like you did for the PMIMR register?

Yeah it went from 0 to just a few bits, but it should have been the ~
of that, you're right.  Will fix & test and resend.

-- 
Jesse Barnes, Intel Open Source Technology Center