From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] drm/i915: small semaphore fix
Date: Thu, 1 Sep 2011 19:51:11 -0700
Message-ID: <20110901195111.0b338102@bwidawsk.net>
References: <1314820042-6169-1-git-send-email-ben@bwidawsk.net>
	<87wrdsb0o4.fsf@eliezer.anholt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id D3F2A9E848
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  1 Sep 2011 19:51:14 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
	by cloud01.chad-versace.us (Postfix) with ESMTP id D54401D41C4
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  2 Sep 2011 02:54:29 +0000 (UTC)
Received: from cloud01.chad-versace.us ([127.0.0.1])
	by localhost (cloud01.static.cloud-ips.com [127.0.0.1]) (amavisd-new,
	port 10024)
	with ESMTP id uWYGdF4hfHIC for <intel-gfx@lists.freedesktop.org>;
	Fri,  2 Sep 2011 02:54:06 +0000 (UTC)
Received: from bwidawsk.net (static-50-53-41-91.bvtn.or.frontiernet.net
	[50.53.41.91])
	by cloud01.chad-versace.us (Postfix) with ESMTPSA id 01C561D4094
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  2 Sep 2011 02:54:02 +0000 (UTC)
In-Reply-To: <87wrdsb0o4.fsf@eliezer.anholt.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 01 Sep 2011 11:03:07 -0700
Eric Anholt <eric@anholt.net> wrote:

> On Wed, 31 Aug 2011 12:47:22 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > Assertion + unsigned helps catch potential issues.
> > 
> > From the docs it is hard to tell if the global GTT flag is actually
> > needed, but it shouldn't hurt.
> 
> We're updating a register, not the GTT, so I don't see why the flag
> would be relevant.

The patch is as (ir)relevant as without it which implies PPGTT. The
reason it was there is in another branch I was planning to implement
memory based semaphores.

I have the refactor patch coming soon, should probably ignore this.