From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Subject: Re: [PATCH] i915: Enable SDVO hotplug interrupts for
	HDMI and DVI
Date: Tue, 20 Sep 2011 10:38:57 +0100
Message-ID: <201109201038.58129.simon.farnsworth@onelan.co.uk>
References: <1313574741-31193-1-git-send-email-simon.farnsworth@onelan.co.uk>
	<yun8vpjhmdz.fsf@aiko.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from claranet-outbound-smtp00.uk.clara.net
	(claranet-outbound-smtp00.uk.clara.net [195.8.89.33])
	by gabe.freedesktop.org (Postfix) with ESMTP id B4D539E963
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 20 Sep 2011 02:39:03 -0700 (PDT)
In-Reply-To: <yun8vpjhmdz.fsf@aiko.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tuesday 20 September 2011, Keith Packard <keithp@keithp.com> wrote:
> On Wed, 17 Aug 2011 10:52:21 +0100, Simon Farnsworth 
<simon.farnsworth@onelan.co.uk> wrote:
> >  static bool
> >  intel_sdvo_multifunc_encoder(struct intel_sdvo *intel_sdvo)
> > 
> > @@ -2062,7 +2053,10 @@ intel_sdvo_dvi_init(struct intel_sdvo *intel_sdvo,
> > int device)
> > 
> >  	intel_connector = &intel_sdvo_connector->base;
> >  	connector = &intel_connector->base;
> > 
> > -	connector->polled = DRM_CONNECTOR_POLL_CONNECT |
> > DRM_CONNECTOR_POLL_DISCONNECT; +	if
> > (intel_sdvo_supports_hotplug(intel_sdvo) & (1 << device))
> > +		connector->polled = DRM_CONNECTOR_POLL_HPD;
> > +	else
> > +		connector->polled = DRM_CONNECTOR_POLL_CONNECT |
> > DRM_CONNECTOR_POLL_DISCONNECT;
> > 
> >  	encoder->encoder_type = DRM_MODE_ENCODER_TMDS;
> >  	connector->connector_type = DRM_MODE_CONNECTOR_DVID;
> > 
> > @@ -2587,6 +2581,11 @@ bool intel_sdvo_init(struct drm_device *dev, int
> > sdvo_reg)
> > 
> >  						    &intel_sdvo->pixel_clock_max))
> >  		
> >  		goto err;
> > 
> > +        if (intel_sdvo_supports_hotplug(intel_sdvo)) {
> > +		intel_encoder->hot_plug = intel_sdvo_do_hotplug;
> > +		intel_sdvo_set_hotplug(intel_sdvo);
> > +	}
> > +
> 
> This all looks quite reasonable, about the only thing I would suggest is
> that you avoid calling intel_sdvo_supports_hotplug twice in
> intel_sdvo_init and simply look at connector->polled to see if the HPD
> bit is set.

V2 patch coming up - I'll check connector->polled in intel_sdvo_init, and rely 
on the call to intel_sdvo_output_setup calling a connector-specific output 
function (in my case, intel_sdvo_dvi_init) that sets it correctly.
-- 
Simon Farnsworth
Software Engineer
ONELAN Limited
http://www.onelan.com/