From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 6/9] drm/i915: Make sure eDP power is on before using aux channel Date: Wed, 21 Sep 2011 09:20:01 +0530 Message-ID: <20110921092001.0b65bd3f@jbarnes-x220> References: <1316470923-27832-1-git-send-email-keithp@keithp.com> <1316470923-27832-7-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 64AC49E78C for ; Tue, 20 Sep 2011 20:50:15 -0700 (PDT) In-Reply-To: <1316470923-27832-7-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 19 Sep 2011 15:22:00 -0700 Keith Packard wrote: > The eDP panel may not be able to respond to aux channel communications > unless it has power supplied. During mode setting, power may be > cut-off during panel power sequencing. Make sure that any aux channel > communications will work by forcing vdd power active as needed. > > This also delays after turning power on and off to ensure that the > panel is keeping up. > > Signed-off-by: Keith Packard This one mixes up lots of cleanups plus the EDID read with the power changes. I'm worried about the VDD smashing as well; we have lots of bugs in the PPS hardware around VDD vs full PPS. We need to make sure appropriate delays are in place when transitioning from one to another. In what paths are we trying to do accesses without power applied? Looks like mainly edid? I see the next patch handles the timing stuff, I assume it's ok. Jesse