From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: kicking rings considered harmful Date: Wed, 28 Sep 2011 10:53:39 +0200 Message-ID: <20110928085339.GA2863@phenom.ffwll.local> References: <1317059990-1922-1-git-send-email-daniel.vetter@ffwll.ch> <20110926222201.1ca2afcd@bwidawsk.net> <20110927100322.GA2785@phenom.ffwll.local> <20110927094614.158112a2@bwidawsk.net> <20110927180317.GC2785@phenom.ffwll.local> <20110927123859.5cd58ba8@bwidawsk.net> <20110927183431.2726c0f5@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C7469E7F7 for ; Wed, 28 Sep 2011 01:53:09 -0700 (PDT) Received: by wwf27 with SMTP id 27so7053365wwf.12 for ; Wed, 28 Sep 2011 01:53:08 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , Ben Widawsky , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, Sep 28, 2011 at 09:47:58AM +0100, Chris Wilson wrote: > On Tue, 27 Sep 2011 18:34:31 -0700, Ben Widawsky wrote: > > I'd definitely be in favo(u)r of removing the kick_ring() if it isn't really > > useful anymore. It has some forcewake race if I remember correctly which I > > never bothered to fix. > > Agreed, enough brutality, kill the kick_ring! Actually, what about moving it into the reset-handler, kinda as a soft-reset? If we detect that the gpu hangs again, we could then reset it for real. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48