From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 01/21] drm/i915: Enable digital port hotplug on PCH systems Date: Fri, 30 Sep 2011 18:17:32 +0200 Message-ID: <20110930161732.GA2859@phenom.ffwll.local> References: <20110923085243.6e4b7b4c@jbarnes-x220> <1317344993-24945-1-git-send-email-keithp@keithp.com> <1317344993-24945-2-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1317344993-24945-2-git-send-email-keithp@keithp.com> Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 29, 2011 at 06:09:33PM -0700, Keith Packard wrote: > We were relying on the BIOS to set these bits, which doesn't always > happen. > > Signed-off-by: Keith Packard Ok, I'll try to increase our review-bandwidth for modesetting stuff by jumping into this maze myself. For the moment I'll shortly explain what I've actually checked so you know how much weight/little to attach to my r-b's. Checked with docs, noticed that the public one's lack register addresses for PCH regs ... Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48