From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 12/21] drm/i915: Ensure eDP powered up during DP_SET_POWER operation in dp_prepare Date: Fri, 30 Sep 2011 19:45:02 +0200 Message-ID: <20110930174502.GL2859@phenom.ffwll.local> References: <20110923085243.6e4b7b4c@jbarnes-x220> <1317344993-24945-1-git-send-email-keithp@keithp.com> <1317344993-24945-13-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1317344993-24945-13-git-send-email-keithp@keithp.com> Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Sep 29, 2011 at 06:09:44PM -0700, Keith Packard wrote: > Any call to intel_dp_sink_dpms must ensure that the panel has power so > that the DP_SET_POWER operation will be correctly received. The only > one missing this was in intel_dp_prepare. > > Signed-off-by: Keith Packard If I understand things correctly we don't need the vdd_on/off on dpms off because the panel is running and has power. Assuming my understanding is correct: Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48