From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/2] drm: Add Panel Self Refresh DP addresses Date: Tue, 4 Oct 2011 02:38:27 +0000 Message-ID: <20111004023827.GA6319@cloud01> References: <1316557787-14935-1-git-send-email-ben@bwidawsk.net> <20111003221413.GA11096@bolo_yeung.jf.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2011697533==" Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AD4D9E8AB for ; Mon, 3 Oct 2011 19:34:53 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2011697533== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 03, 2011 at 04:31:22PM -0700, Keith Packard wrote: > On Mon, 3 Oct 2011 15:14:14 -0700, Ben Widawsky wrote: >=20 > > +# define DP_PSR_SUPPORTED 1 >=20 > That's PSR version 1, not just a simple boolean Ok. >=20 > > +# define DP_PSR_SETUP_TIME_330 (0 << 1) > > +# define DP_PSR_SETUP_TIME_275 (1 << 1) > > +# define DP_PSR_SETUP_TIME_220 (2 << 1) > > +# define DP_PSR_SETUP_TIME_165 (3 << 1) > > +# define DP_PSR_SETUP_TIME_110 (4 << 1) > > +# define DP_PSR_SETUP_TIME_55 (5 << 1) > > +# define DP_PSR_SETUP_TIME_0 (6 << 1) >=20 > Need a DP_PSR_SETUP_TIME_MASK to indicate which bits are relevant here Ok. >=20 > > +# define DP_PSR_MAIN_LIKE_ACTIVE (1 << 1) >=20 > LINK, I assume Yes >=20 >=20 > > +# define DP_PSR_SINK_INACTIVE (1 << 0) > > +# define DP_PSR_SINK_ACTIVE_SRC_SYNCED (1 << 1) > > +# define DP_PSR_SINK_ACTIVE_RFB (1 << 2) > > +# define DP_PSR_SINK_ACTIVE_SINK_SYNCED (1 << 3) > > +# define DP_PSR_SINK_ACTIVE_RESYNC (1 << 4) > > +# define DP_PSR_SINK_INTERNAL_ERROR (1 << 7) >=20 > These are all wrong. Bits 2:0 are a 3 bit field. That's really odd. Not sure how I screwed that up so badly. Good catch. I guess you'll want a mask here too then. Ben --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJOinGjAAoJEL9nTIiJEj0pXYwH/i48NovfnvFbA6Jt/w1R5Uwv 4/VnjgGR976dGPUtgcMKoLZu6ou3a5oqIv3h0x7U113UBkAIgshle12f8zZ42ZVM PggHUPNnROjCcvuough5K7hxgzURsWszRf07wQnSY6dM55m0c9wcVyiwVpzivDcj L0/l5eHTaM0jPQOWkcGsZ22mP5CbXprMhuL5E+kio+8Y/nFI93UTveIr5wpLliG2 z+d9pXK3+j1a7B6JDJgwOzDwEJ5Dgzm/IspMaUV2gVK1t4HG9Ci3AvQeJMXpJomY ijZSk4U6Wv7tiOd9rYE6dJwP4uAiSILfVpKq5DCY/HpmByY3pJ8M8kosKpqQ/D0= =8OQG -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC-- --===============2011697533== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2011697533==--