From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/3] i915: Remove implied length of 2 from GFX_OP_PIPE_CONTROL #define. Date: Tue, 11 Oct 2011 11:39:36 -0700 Message-ID: <20111011113936.7a4291d0@bwidawsk.net> References: <1317708160-1761-1-git-send-email-kenneth@whitecape.org> <20111011110917.GC2962@phenom.ffwll.local> <20111011102004.34e8a517@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EBD69E73D for ; Tue, 11 Oct 2011 11:39:34 -0700 (PDT) In-Reply-To: <20111011102004.34e8a517@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Oct 2011 10:20:04 -0700 Jesse Barnes wrote: > On Tue, 11 Oct 2011 13:09:17 +0200 > Daniel Vetter wrote: > > > Switching to PIPE_CONTROL with the snb workaround seems to fix the hangs I > > see when running cairo-perf-traces. > > > > Tested-by: Daniel Vetter > > Ah wow, so it actually fixes a bug. Let's get this upstream soon then; > Ben do you want to re-post or should I? > > Thanks, If nobody else thinks it's a good idea, just slap on my r-b and call it done. I don't care enough to repost or ask you to do so. Ben