From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 3/3] drm/i915: Force sync command ordering Date: Tue, 11 Oct 2011 11:44:44 -0700 Message-ID: <20111011114444.4ab95e8e@bwidawsk.net> References: <1318357916-12661-1-git-send-email-ben@bwidawsk.net> <1318357916-12661-4-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 159C29E73D for ; Tue, 11 Oct 2011 11:44:42 -0700 (PDT) In-Reply-To: <1318357916-12661-4-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 11 Oct 2011 11:31:56 -0700 Ben Widawsky wrote: > This will strongly order synchronization commands with respect to 3d > state and 3d primitive commands. AFAIK, this shouldn't impact anything > as these sync commands are all for privileged (or ppgtt) batches only, > so user space should not be relying on this, and the kernel wouldn't be > relying on 3d state or primitive commands. > > This will help when we enable PPGTT, and perhaps this synchronization is > currently useful and I just don't realize it. > > This was found through doc inspection by Ken and applies to Gen6+; > > Reported-by: Kenneth Graunke > Signed-off-by: Ben Widawsky > --- What I forgot to mention is certain docs say this bit must be set.