From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/i915: Force sync command ordering (Gen6+) Date: Thu, 13 Oct 2011 10:44:25 +0200 Message-ID: <20111013084425.GD2938@phenom.ffwll.local> References: <1318394633-11143-1-git-send-email-ben@bwidawsk.net> <1318460182-21302-1-git-send-email-ben@bwidawsk.net> <1318460182-21302-3-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 409779EB20 for ; Thu, 13 Oct 2011 01:43:44 -0700 (PDT) Received: by wwf27 with SMTP id 27so1077519wwf.12 for ; Thu, 13 Oct 2011 01:43:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1318460182-21302-3-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 12, 2011 at 03:56:20PM -0700, Ben Widawsky wrote: > The docs say this is required for Gen7, and since the bit was added for > Gen6, we are also setting it there pit pf paranoia. Particularly as > Chris points out, if PIPE_CONTROL counts as a 3d state packet. > > This was found through doc inspection by Ken and applies to Gen6+; > > Reported-by: Kenneth Graunke > Signed-off-by: Ben Widawsky > Reviewed-by: Chris Wilson Now even I get it, thanks to the comment ;-) Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48