From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 4/4] drm/i915: Use eb for more stuff
Date: Thu, 13 Oct 2011 14:49:39 +0200
Message-ID: <20111013124939.GG2938@phenom.ffwll.local>
References: <1318394633-11143-1-git-send-email-ben@bwidawsk.net>
	<1318460182-21302-1-git-send-email-ben@bwidawsk.net>
	<1318460182-21302-5-git-send-email-ben@bwidawsk.net>
	<20111013085825.GF2938@phenom.ffwll.local>
	<e0d58a$1ru7mp@orsmga002.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41])
	by gabe.freedesktop.org (Postfix) with ESMTP id BCEDB9E7B3
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Oct 2011 05:48:58 -0700 (PDT)
Received: by wwf10 with SMTP id 10so74261wwf.0
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Oct 2011 05:48:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <e0d58a$1ru7mp@orsmga002.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Oct 13, 2011 at 01:00:02PM +0100, Chris Wilson wrote:
> On Thu, 13 Oct 2011 10:58:25 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Oct 12, 2011 at 03:56:22PM -0700, Ben Widawsky wrote:
> > > This refactor is useful for some future work I'll be doing on the
> > > execbuffer path. In addition to being a pretty easy prerequisite, it
> > > also helped me track down the bug uncovered in the first patch.
> > > 
> > > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> > > ---
> > >  drivers/gpu/drm/i915/i915_gem_execbuffer.c |  102 ++++++++++++++--------------
> > >  1 files changed, 51 insertions(+), 51 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > index 182a2b9..b3beaae 100644
> > > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > @@ -40,6 +40,16 @@ struct change_domains {
> > >  	uint32_t flips;
> > >  };
> > >  
> > > +struct eb_objects {
> > > +	struct drm_i915_gem_object *batch_obj;
> > > +	struct list_head objects;
> > > +	int buffer_count;
> > > +	int mode;
> > > +	int and;
> > 
> > While you whack this code, can you do an s/and/end, I think that's just a
> > typo ...
> 
> It was meant to be 'and' since it was the value of the mask I was anding
> with. I'm sorry I appear to have spent too much time inside the Xserver,
> end = and + 1.

Indeed, maybe s/and/hash_mask/?
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48