From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 3/4] drm/i915: extract constant offset
	setting
Date: Thu, 13 Oct 2011 10:14:10 -0700
Message-ID: <20111013171409.GA32465@bolo_yeung.jf.intel.com>
References: <1318394633-11143-1-git-send-email-ben@bwidawsk.net>
	<1318460182-21302-1-git-send-email-ben@bwidawsk.net>
	<1318460182-21302-4-git-send-email-ben@bwidawsk.net>
	<20111013084629.GE2938@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id BE2DD9E8D0
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Oct 2011 10:15:20 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20111013084629.GE2938@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Oct 13, 2011 at 10:46:29AM +0200, Daniel Vetter wrote:
> On Wed, Oct 12, 2011 at 03:56:21PM -0700, Ben Widawsky wrote:
> > Simple refactor.
> > 
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> 
> Imo you can fold this in with the fix. Usually it's good to separate fixes
> from refactoring, but it this special case of just moving around code
> blocks, it doesn't add anything.
> 

I agree, and I had it like this locally, but Chris suggested that he
preferred the separation as it highlighted the fix.

I largely do not care, I just want an r-b. So you two can fight it out.

Ben