From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/3] drm/i915: Rename PIPE_CONTROL bit defines to be less terse. Date: Sat, 15 Oct 2011 12:26:19 -0700 Message-ID: <20111015122619.0e5c0380@bwidawsk.net> References: <1318369270-1568-1-git-send-email-daniel.vetter@ffwll.ch> <1318369270-1568-2-git-send-email-daniel.vetter@ffwll.ch> <20111011165116.537f0708@bwidawsk.net> <20111015140117.GB2819@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id B30209E74E for ; Sat, 15 Oct 2011 12:26:22 -0700 (PDT) In-Reply-To: <20111015140117.GB2819@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Sat, 15 Oct 2011 16:01:17 +0200 Daniel Vetter wrote: > On Tue, Oct 11, 2011 at 04:51:16PM -0700, Ben Widawsky wrote: > > I thought we all agreed that "PIPE_CONTROL_WRITE_FLUSH" doesn't make > > sense for Gen6? Or was that just me agreeing with myself? > > I couldn't find any comment of yours to that effect ... :p You'd be much > happier if I add a RENDER_CACHE_FLUSH for gen6+? > > Cheers, Daniel I really want to make these things match the docs as closely as possible. Especially PIPE_CONTROL which I know I will refer to over and over. Like I said, r-b from me either way, but if you redo the series anyway for some reason, I would prefer that. Ben