From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/i915: Ivybridge still has fences! Date: Sun, 23 Oct 2011 12:12:00 +0200 Message-ID: <20111023101200.GC2953@phenom.ffwll.local> References: <1318189923-4609-1-git-send-email-daniel.vetter@ffwll.ch> <20111010105822.58114c0e@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id C36EB9E9CC for ; Sun, 23 Oct 2011 03:11:10 -0700 (PDT) Received: by wwf10 with SMTP id 10so6177512wwf.12 for ; Sun, 23 Oct 2011 03:11:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20111010105822.58114c0e@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@kernel.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Oct 10, 2011 at 10:58:22AM -0700, Jesse Barnes wrote: > On Sun, 9 Oct 2011 21:52:01 +0200 > Daniel Vetter wrote: > > > So don't forget to restore them on resume and dump them into > > the error state. > > This should probably just be >= 6 instead; I don't think we're getting > rid of fences anytime soon. As discussed on irc >= 6 is a bit hard to do in a switch statement ;-) Do you want me to resend the patches using the gcc ranged switch extension suggested by Adam Jackson (i.e. 6..UINT_MAX)? Or can you slap your r-b on them as-is? -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48