From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 01/11] drm: add plane support
Date: Tue, 25 Oct 2011 13:18:32 +0200
Message-ID: <20111025131832.7e05c392@jbarnes-x220>
References: <1319536026-2877-1-git-send-email-jbarnes@virtuousgeek.org>
	<1319536026-2877-2-git-send-email-jbarnes@virtuousgeek.org>
	<4EA6950E.7020905@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id DE2419E96B
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 25 Oct 2011 04:18:37 -0700 (PDT)
In-Reply-To: <4EA6950E.7020905@samsung.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: intel-gfx@lists.freedesktop.org, "kyungmin.park@samsung.com >> =?UTF-8?B?67CV6rK966+8?=" <kyungmin.park@samsung.com>, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 25 Oct 2011 19:53:02 +0900
Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> > +/**
> > + * drm_plane - central DRM plane control structure
> > + * @dev: DRM device this plane belongs to
> > + * @kdev: kernel device
> > + * @attr: kdev attributes
> > + * @head: for list management
> > + * @base: base mode object
> > + * @crtc_x: x position of plane (relative to pipe base)
> > + * @crtc_y: y position of plane
> > + * @x: x offset into fb
> > + * @y: y offset into fb
> Above 4 members don't be used.

Oops yeah, I'll fix up the comments.

> > +
> > +struct drm_mode_get_plane {
> > +	__u64 format_type_ptr;
> > +	__u32 plane_id;
> > +
> > +	__u32 crtc_id;
> > +	__u32 fb_id;
> > +
> > +	__u32 possible_crtcs;
> > +	__u32 gamma_size;
> > +
> > +	__u32 count_format_types;
> > +};
> 
> I wonder why doesn't give to user crtc_x, crtc_y, crtc_w, crtc_h
> information?

It could, but the caller should already know was my thinking.  Would
you like those bits returned?

Jesse