From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 01/11] drm: add plane support Date: Thu, 27 Oct 2011 08:31:00 -0700 Message-ID: <20111027083100.4983f5f9@jbarnes-desktop> References: <1319536026-2877-1-git-send-email-jbarnes@virtuousgeek.org> <1319536026-2877-2-git-send-email-jbarnes@virtuousgeek.org> <4EA79D37.4080007@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0259480594==" Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id 4CDC2A0CD3 for ; Thu, 27 Oct 2011 08:31:18 -0700 (PDT) In-Reply-To: <4EA79D37.4080007@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Joonyoung Shim Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0259480594== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/=LaD2oyvtjo09nUyAy1F0yZ"; protocol="application/pgp-signature" --Sig_/=LaD2oyvtjo09nUyAy1F0yZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 26 Oct 2011 14:40:07 +0900 Joonyoung Shim wrote: > 10/25/2011 06:46 PM, Jesse Barnes =EC=93=B4 =EA=B8=80: >=20 > [snip] > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index 8020798..d7f03aa 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -44,6 +44,7 @@ struct drm_framebuffer; > > #define DRM_MODE_OBJECT_PROPERTY 0xb0b0b0b0 > > #define DRM_MODE_OBJECT_FB 0xfbfbfbfb > > #define DRM_MODE_OBJECT_BLOB 0xbbbbbbbb > > +#define DRM_MODE_OBJECT_PLANE 0xeeeeeeee > > > > struct drm_mode_object { > > uint32_t id; > > @@ -278,6 +279,7 @@ struct drm_crtc; > > struct drm_connector; > > struct drm_encoder; > > struct drm_pending_vblank_event; > > +struct drm_plane; > > > > /** > > * drm_crtc_funcs - control CRTCs for a given device > > @@ -536,6 +538,58 @@ struct drm_connector { > > }; > > > > /** > > + * drm_plane_funcs - driver plane control functions > > + * @update_plane: update the plane configuration > > + */ > > +struct drm_plane_funcs { > > + int (*update_plane)(struct drm_plane *plane, > > + struct drm_crtc *crtc, struct drm_framebuffer *fb, > > + int crtc_x, int crtc_y, > > + unsigned int crtc_w, unsigned int crtc_h, > > + uint32_t src_x, uint32_t src_y, > > + uint32_t src_w, uint32_t src_h); > > + int (*disable_plane)(struct drm_plane *plane); > > +}; >=20 > How about add destroy() function and call it in > drm_mode_config_cleanup()? Oh good idea; destroy will be needed for hot plug. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/=LaD2oyvtjo09nUyAy1F0yZ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOqXk0AAoJEIEoDkX4Qk9h42QP/iv/hypv0EIq+hT/0VV/+3sb +YL570z0mujwjyMYqsMxjRc/eISfCqsFSvC+NJyj1cTWneIhaS1tRVQMKv96oebd bptWd5UV8Q9aU8UYJXAVTvSc6ml1ESvrt1DnE7Tnnl/YHA8BjYqEis091YS4cl8x F+Mi90iBf4tMimwzQcNgZwi0ZjFZqamHi9GxsEpHGCeVf0Kl2fIWbjdr+ttLfnwi 4Eu/w8K0hHJ36bItxff9u1Z8EAy8e+xix3RJ53UtL9alkmOSQTQn/f8TR124vCKS t4eSNVXb253Ce8CPKbHxORHZiqWBDyzgVA3tbEibnUDcmbCotiq8BI5I5BS8ufBh O15O0/0W/rQB0aWmRfEqLxhnpK/efyTPPOXeLLImbV4h2vCDZ6fxfmEnV0Zh+Mn4 t2Kowye4MwvfSp9Fbd+yQQyPT72VGH2bbTXtwig44Cfrr6JaAKmzSBMbXYxvWSlr DiJ6EcX3MoskDQkmJsiDhge+HB2Gtqd8OiaoxVJX9WFGtfzyeRhHUkKOMHgeIVk2 b1XPGTE+v1LBbPLaiIxKMGJo4ibr0HDXTBgaqOWWmKCm/TClyb4XMfKIwK6sODVh 8DddtBbTUrhVGJJew4LlIM43lvweKsXaO4cvSOPj0myML8Hn60VxhdPEgVaJ1eRX vQQSux47xZd2zC9PjgBh =yTN/ -----END PGP SIGNATURE----- --Sig_/=LaD2oyvtjo09nUyAy1F0yZ-- --===============0259480594== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0259480594==--