From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v3] drm/i915: Fix recursive calls to unmap
Date: Mon, 31 Oct 2011 08:45:53 +0100
Message-ID: <20111031074553.GB2920@phenom.ffwll.local>
References: <1320031005-8729-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43])
	by gabe.freedesktop.org (Postfix) with ESMTP id D7AC89E79A
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 31 Oct 2011 00:44:57 -0700 (PDT)
Received: by wwf4 with SMTP id 4so943524wwf.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 31 Oct 2011 00:44:57 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1320031005-8729-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Oct 30, 2011 at 08:16:45PM -0700, Ben Widawsky wrote:

[snip]

> -int
> -i915_gpu_idle(struct drm_device *dev)
> +int i915_gem_gpu_idle(struct drm_device *dev, bool strictly_idle)
>  {
>  	drm_i915_private_t *dev_priv = dev->dev_private;
>  	int ret, i;
>  
>  	/* Flush everything onto the inactive list. */
>  	for (i = 0; i < I915_NUM_RINGS; i++) {
> -		ret = i915_ring_idle(&dev_priv->ring[i]);
> +		ret = i915_ring_idle(&dev_priv->ring[i], strictly_idle);

One bikeshed: When introducing a new parametere all over the tree, I
prefere consistent naming for it, i.e. s/strictly_idle/defer_retirement/
...

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48