From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/5] drm/i915: refactor ring error state capture to use arrays Date: Mon, 31 Oct 2011 08:53:29 +0100 Message-ID: <20111031075329.GC2920@phenom.ffwll.local> References: <1320001932-1846-1-git-send-email-daniel.vetter@ffwll.ch> <1320001932-1846-4-git-send-email-daniel.vetter@ffwll.ch> <20111030184750.04997faf@bwidawsk.net> <20111030185005.5997ff4b@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id A87019EB76 for ; Mon, 31 Oct 2011 00:52:34 -0700 (PDT) Received: by wyf28 with SMTP id 28so445446wyf.36 for ; Mon, 31 Oct 2011 00:52:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20111030185005.5997ff4b@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Daniel Vetter , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Sun, Oct 30, 2011 at 06:50:05PM -0700, Ben Widawsky wrote: > Ah, just saw patch 5... I guess I find this a little weird way to break > it up, but I think I did a much worse job in my patches. Safe when the change is really small (i.e. a few one-liner hunks), always separate the refactor from the actual code change. It's just damn hard to spot a small functional change amid tons of code movement, making proper review impossible. That's also the reason I'll only ever smash an acked-by on top of a massive refactor - you can't review that kind of stuff without completely redoing the patch yourself. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48