From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places Date: Wed, 2 Nov 2011 09:20:19 -0700 Message-ID: <20111102092019.3a635632@jbarnes-desktop> References: <1320214830-12696-1-git-send-email-keithp@keithp.com> <1320214830-12696-4-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/=fux+Y21T..6.BTqp2EHD9J"; protocol="application/pgp-signature" Return-path: In-Reply-To: <1320214830-12696-4-git-send-email-keithp@keithp.com> Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --Sig_/=fux+Y21T..6.BTqp2EHD9J Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 1 Nov 2011 23:20:26 -0700 Keith Packard wrote: > PCH eDP has many of the same needs as regular PCH DP connections, > including the DP_CTl bit settings, the TRANS_DP_CTL register. >=20 > Signed-off-by: Keith Packard > --- > drivers/gpu/drm/i915/intel_display.c | 3 +- > drivers/gpu/drm/i915/intel_dp.c | 112 ++++++++++++++++++++++++----= ------ > 2 files changed, 81 insertions(+), 34 deletions(-) >=20 Might be nice to have some function pointers to handle the different types better. But that could be a separate cleanup. I'd rather have duplicated code than fragile code... Reviewed-by: Jesse Barnes But I was curious about this hunk: @@ -766,10 +766,10 @@ intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_di= splay_mode *mode, continue; =20 intel_dp =3D enc_to_intel_dp(encoder); - if (intel_dp->base.type =3D=3D INTEL_OUTPUT_DISPLAYPORT) { + if (intel_dp->base.type =3D=3D INTEL_OUTPUT_DISPLAYPORT || is_pch_edp(in= tel_dp)) { lane_count =3D intel_dp->lane_count; break; - } else if (is_edp(intel_dp)) { + } else if (is_cpu_edp(intel_dp)) { lane_count =3D dev_priv->edp.lanes; break; } I guess this means we can't trust the BIOS settings for PCH eDP? --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/=fux+Y21T..6.BTqp2EHD9J Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOsW3DAAoJEIEoDkX4Qk9hlOoP/3BLRllQuUbtNPfRGex2ZVdT sq7JefaQfeGTfNaQ34X8GUbwcsWmEJNBD1PBvy4K031sGy+iCBQCc8upWH39CbwC aGGlwfOpTjtoPhN2doCSJBoUOoFdnS+B2/igcxKguqi/1S/RnUvuW0o8QAp7tmFn HwowigrQRK3mldYU4MTZzOYAe4C0urwWQDWjJEGSqp3RTmiF2Kcw/uuxmYjKBY6+ xJRQYIWH7P/ZAxFKCa6GZgIj484HTHGfQallp0/IH7aH6WCk7b3JmzP0I58G7zHa MQqrEumdka4KYoqrn6vpknD1cYYig1I/JhdFmtx3G2rJhjOBYykmbSq25Rcky+k2 ClmDxrg11Vbwn4wH132fjPcVfYueXnWD4xE01dVckGslUnUhFooz/WU5YJSHebk4 YDVf8VCa51Gys0rMp58DOCqZHtLOIP0+NyDVC5T6G/jDN52J6XpgVUqzMszYJM4L ClaafDj9RoESeyYfpOsOKHnIQt0gWZ9/IJKFDAbRWKLtCRyIiUbRaw+/heifw/5x cvADh2GOsBqqUnCt80qEW9N6yhjl/9mfiuudaFLvYWrtuKY9ydNzNRwp6s7RXQo+ fofiUEZzO3cyRMBL/YiYuUn0l/SzC38Kssarho+QWLxdNZx4DXC8x3fadcEMgTbo xCkp/fcY4qY0y0Zov1PN =EnaP -----END PGP SIGNATURE----- --Sig_/=fux+Y21T..6.BTqp2EHD9J--