From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH v3] drm/i915: Fix recursive calls to unmap
Date: Thu, 3 Nov 2011 15:23:39 -0700
Message-ID: <20111103152339.46fe6ce8@bwidawsk.net>
References: <1320031005-8729-1-git-send-email-ben@bwidawsk.net>
	<CAPM=9tykBe0+P6C7gDNZ6hUUJ5Rst1MiuMWe2hiT_oBbs6ijpg@mail.gmail.com>
	<20111103044730.GA19799@cloud01>
	<CAPM=9twNJFYEmKapA8N5ahmzzba=4hfFkzBEDRiVNSB6jRoK9A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id EFF4C9EB4A
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  3 Nov 2011 15:23:46 -0700 (PDT)
In-Reply-To: <CAPM=9twNJFYEmKapA8N5ahmzzba=4hfFkzBEDRiVNSB6jRoK9A@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Dave Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 3 Nov 2011 20:19:23 +0000
Dave Airlie <airlied@gmail.com> wrote:

> >> >
> >> > The solution here is to add a new flag to the call chain which gives the
> >> > routines the information they need to possibly defer actions which may
> >> > cause us to recurse. A macro has been defined to replace i915_gpu_idle
> >> > which defaults to the old behavior.
> >> >
> >> > Kudos to Chris for tracking this one down.
> >>
> >> So this fixes the non-VTd case, the VT-d case still hits a recursion
> >> here, for posterity its below.
> 
> Okay I take that back, I got my EL6 kernel rock stable with the
> correct blend of backported bits.
> 
> So ignore that backtrace, however I did get another IOMMU hang on my
> upstream kernel with gem_linear_blits,
> 
> so this should be fine to merge but I'm guessing we have more
> debugging to do on the VT-d cases.
> 
> Dave.

Does it pass your original failing case?