From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/5] drm: add plane support Date: Fri, 4 Nov 2011 07:10:41 -0700 Message-ID: <20111104071041.60aa47d8@jbarnes-desktop> References: <1320264203-18715-1-git-send-email-jbarnes@virtuousgeek.org> <1320264203-18715-2-git-send-email-jbarnes@virtuousgeek.org> <4EB34C52.2010104@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2013404143==" Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id 07AD89F0F7 for ; Fri, 4 Nov 2011 07:10:48 -0700 (PDT) In-Reply-To: <4EB34C52.2010104@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Joonyoung Shim Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rob.clark@linaro.org List-Id: intel-gfx@lists.freedesktop.org --===============2013404143== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/V+t.=rh/gnDIRLQH58uZztu"; protocol="application/pgp-signature" --Sig_/V+t.=rh/gnDIRLQH58uZztu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 04 Nov 2011 11:22:10 +0900 Joonyoung Shim wrote: > > +struct drm_plane { > > + struct drm_device *dev; > > + struct device kdev; > > + struct device_attribute *attr; > > + struct list_head head; > > + > > + struct drm_mode_object base; > > + > > + uint32_t possible_crtcs; > > + uint32_t *format_types; > > + uint32_t format_count; > > + > > + struct drm_crtc *crtc; > > + struct drm_framebuffer *fb; >=20 > Where are crtc and fb of struct drm_plane assigned? > First, i did it in device specific update_plane, but can do in > drm_mode_setplane? Yeah it should probably be done in setplane if there's no error. Fixed. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/V+t.=rh/gnDIRLQH58uZztu Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOs/JhAAoJEIEoDkX4Qk9h0M0QAJUpSpfbqlN0jZVQJ7SpIaNj G0DdLSHlZegiHQXc7douVI7jx4Dw1b++uM7eZ3hQ3tbgVVG3eXRyP/wDFX+fHQNM 9tTW2IqGvBpY9hcL8Za5Sr45VT2KjjVkbKwgnuNOPnBHwofwrnFg9w6l8lYxgCQP 2E99Uc9Uj/xuWv0+MF25oQvp2TXKmtIICvWU6YzB3BUv4alWopqBgRLovJjwNsBd 1X9yNhacVlGtFnN4SRIAkDYUi8j59JPuSzE7LAcd/1f5vz/FqXzN8j4Ur1CVBMdA j3AqUelA8AzvScCad2niMPxcCnUKP9cb64Q0xrOJH92H3akXqxqAiLx1JE8rlXFr FRQTDJvxlq0kwQKoWN1fXDEZ+zsNPjBMd6hAzHldhU4jTbUnm9ooD0aRkxh6xaSX 204sNTJ8UXK9g3luPttQJGJCOA2vzsrFJijGI58I2JBYx5/zpef2v3+QcfjxavAc fsF+JAYTguy52xoya3kRrf/xMFJ/zcHoY/OLG6UpQ+wyxpUXKd1z7GvwgQIr34hO mRgFe7Bgc4iGy26WhDm1ppMXjVayQeLLzCltI04o+RYzzGIz7MlDNHxfAIypBE72 lzmrhKfVAKwG74YaLSBRz9DWVBNlFX4BejD9hT8mLyA9lkPg27l0s3D9RNQEGrWp hPJ178LoWm8i7Aaj1spT =r4nO -----END PGP SIGNATURE----- --Sig_/V+t.=rh/gnDIRLQH58uZztu-- --===============2013404143== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2013404143==--