From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/5] drm: add an fb creation ioctl that takes a pixel format Date: Fri, 4 Nov 2011 07:13:26 -0700 Message-ID: <20111104071326.5d94f55d@jbarnes-desktop> References: <1320264203-18715-1-git-send-email-jbarnes@virtuousgeek.org> <1320264203-18715-3-git-send-email-jbarnes@virtuousgeek.org> <4EB3957E.1040803@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2090339732==" Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 96152A0D3B for ; Fri, 4 Nov 2011 07:13:29 -0700 (PDT) In-Reply-To: <4EB3957E.1040803@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Joonyoung Shim Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rob.clark@linaro.org List-Id: intel-gfx@lists.freedesktop.org --===============2090339732== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/QU7nC.gBEj0AUU3oYBusLdr"; protocol="application/pgp-signature" --Sig_/QU7nC.gBEj0AUU3oYBusLdr Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 04 Nov 2011 16:34:22 +0900 Joonyoung Shim wrote: > > + case V4L2_PIX_FMT_RGB24: > > + *depth =3D 24; > > + *bpp =3D 24; > > + break; =20 >=20 > In the depth =3D 24 and bpp =3D 32 case also the pixed_format is > V4L2_PIX_FMT_RGB24, but above function cannot detect it. Oh that's a mistake on my part. RGB24 is generally bpp=3D32. I'll fix that. This is just a compatibility function, so it only needs to handle cases used by current code. I expect future code to use the fourcc values directly. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/QU7nC.gBEj0AUU3oYBusLdr Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOs/MGAAoJEIEoDkX4Qk9h+eQP/ialX46HTR764qlZnpLhWjIz J0kjyGciO9HxdOxKxAUE8ppeT9L5IcJkaXLh4Ujh2rvLiT0bLnXJmGSc6AVmmuFy q9gF/k4ClsgsWEHCVEpjs09z64puOS6krNPMfsnHs6Gi3759HRruIBZFRDuxL+ch rDdwjQrjGcF84A8Y2yEJRico6IgCwjZgS0B1Rcu47wjIEqNDbmGRaHDLVEnO4f8h YotFa8iebLs95oyiP6itaBsL6KY6NLExGR6oPT2Fh6Q8Lj+wtQ3WeLBaBh0RreCr aNNesFzMPGLKw6CfL6crbGjl9VlDkB+8StY7jcpLeIP32z+ACd8YMEU0t80ogOrt HpENw3jImE4PZFAy4v2s3j4+cyHfH1X3dMWSQlFvRTMrZl4pu6W9BtcbF4ekQ7QJ q6Y3QdSRfKCTHB1DXEE6OWnVkP+5a31j/YXUVQTfN9k5eYT4VCgkxx6vzAn/pOH4 0+VIgrOKDBBZjrbx+GVzgeRk4IaJ0STphGdzUgIUIl6DhKeOdI8+NdpomE2IHUxl ib7xy8mouelfdFmaPYR5nyKnCqok/1wtP8mEltA73w173HBk9mbP6onaRIMyCk7f MlOzf/gFNmUnVyPwQ1lTLhOILDJmP4li3p9rc2k8obXMSt6dS+JJPZtGJZHULTvR 3H9c6DXo70ZFuTgquhZg =94Of -----END PGP SIGNATURE----- --Sig_/QU7nC.gBEj0AUU3oYBusLdr-- --===============2090339732== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2090339732==--