From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/i915: Remove extraneous MI_BATCHBUFFER_START from the BLT ring. Date: Sun, 6 Nov 2011 19:03:18 +0100 Message-ID: <20111106180318.GB3126@phenom.ffwll.local> References: <1320601898-1376-1-git-send-email-kenneth@whitecape.org> <1320601898-1376-2-git-send-email-kenneth@whitecape.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C2739E73F for ; Sun, 6 Nov 2011 10:02:18 -0800 (PST) Received: by wwf27 with SMTP id 27so4084164wwf.0 for ; Sun, 06 Nov 2011 10:02:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <1320601898-1376-2-git-send-email-kenneth@whitecape.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Kenneth Graunke Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Nov 06, 2011 at 09:51:38AM -0800, Kenneth Graunke wrote: > This looks like it was part of the BLT ring workaround which the prior > patch removed. However, this is a separate patch because it changes > behavior on shipping platforms. Nope, this should actually be part of your previous patch. ring->private for the blt ring is only set for this gen6 preproduction-hw w/a, so this entire if block should go. You're missing a similar if block in the ring cleanup. I've posted that patch a few months back, but due to the Giant Whitespace Patch haven't yet bothered to forward port it ... Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48