From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/5] drm: add plane support Date: Tue, 8 Nov 2011 08:34:02 -0800 Message-ID: <20111108083402.017512ea@jbarnes-desktop> References: <1320688976-10979-1-git-send-email-jbarnes@virtuousgeek.org> <1320688976-10979-2-git-send-email-jbarnes@virtuousgeek.org> <20111108142037.GB3956@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1464037985==" Return-path: Received: from oproxy7-pub.bluehost.com (oproxy7-pub.bluehost.com [67.222.55.9]) by gabe.freedesktop.org (Postfix) with SMTP id CCEC69EF5D for ; Tue, 8 Nov 2011 08:33:59 -0800 (PST) In-Reply-To: <20111108142037.GB3956@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rob.clark@linaro.org List-Id: intel-gfx@lists.freedesktop.org --===============1464037985== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/I=gsP11Dn0r3HPglFlG2FlC"; protocol="application/pgp-signature" --Sig_/I=gsP11Dn0r3HPglFlG2FlC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 8 Nov 2011 15:20:37 +0100 Daniel Vetter wrote: > On Mon, Nov 07, 2011 at 10:02:52AM -0800, Jesse Barnes wrote: > > Planes are a bit like half-CRTCs. They have a location and fb, but > > don't drive outputs directly. Add support for handling them to the core > > KMS code. > >=20 > > Signed-off-by: Jesse Barnes >=20 > One question belowk, but still: > Reviewed-by: Daniel Vetter >=20 > > /** > > + * drm_plane_funcs - driver plane control functions > > + * @update_plane: update the plane configuration > > + * @disable_plane: shut down the plane > > + * @destroy: clean up plane resources > > + */ > > +struct drm_plane_funcs { > > + int (*update_plane)(struct drm_plane *plane, > > + struct drm_crtc *crtc, struct drm_framebuffer *fb, > > + int crtc_x, int crtc_y, > > + unsigned int crtc_w, unsigned int crtc_h, > > + uint32_t src_x, uint32_t src_y, > > + uint32_t src_w, uint32_t src_h); > > + int (*disable_plane)(struct drm_plane *plane); > > + void (*destroy)(struct drm_plane *plane); > > +}; > > + > > +/** > > + * drm_plane - central DRM plane control structure > > + * @dev: DRM device this plane belongs to > > + * @kdev: kernel device > > + * @attr: kdev attributes > > + * @head: for list management > > + * @base: base mode object > > + * @possible_crtcs: pipes this plane can be bound to > > + * @format_types: array of formats supported by this plane > > + * @format_count: number of formats supported > > + * @crtc: currently bound CRTC > > + * @fb: currently bound fb > > + * @gamma_size: size of gamma table > > + * @gamma_store: gamma correction table > > + * @enabled: enabled flag > > + * @funcs: helper functions > > + * @helper_private: storage for drver layer > > + */ > > +struct drm_plane { > > + struct drm_device *dev; > > + struct device kdev; > > + struct device_attribute *attr; >=20 > What are these two for? Oh I can drop those. I had plans to expose some sysfs stuff, but I don't think I'll bother. Thanks. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/I=gsP11Dn0r3HPglFlG2FlC Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOuVn6AAoJEIEoDkX4Qk9h5H8P/RBn56SL8Tjt5g63DrW+7FoB 5Ox+UguOjDMLfosZ88SYHWQH6YInQDpwCyFabIZOznJeI9JDWq8VFmcbKINUdsM0 hroxVQBSdWKlWdlNk7YDBNdmAwBPDVXwSHnmMpYj2AgdHLe5EMVJjI6QOUKgsreZ U6rK83++fAsbgiulX1t1eAnqJ4VpomlM21WQWYmLGLhuU6WYe8IHGjAopbv4Y/i0 eh7RSHVqRkf2TuA3t7l7gVa2mlisrEcMqSWEXawaCOVkOOVB2hOl62CmNYXoJM1q X0N2lEkYGIlXdsr/xEYrv9ApeJVIoItlvnj3WICFBNSLRPgHC1Z1cS8mqGoiRmCu HC/8Q0EE+4KAiowHgYV0ZqX/qZ/7bxJIF1LR3sgPrA29dYgmC9MZx9H2iB5GwfO+ 0jhNmeq17VkI86keZaFPkEq+cR3JmTk4TXQEPmG1rWhaJ9Ll5UQ89KhXxUBHw0tw W5XgnKYX7dYhFf4G5EgqbRfrJqMfQEuOiRPKzjTNaSPM4w5Owpa9Hja4OzgjgP4s y5XCCZd5XAPisnrkB4EvjJtoFplH25534t8kDq5LNszNagjFJdzsrU6AZ4fGF3UQ 428XLpMi2QZQzpS714ylipEdIzHD/c3Anp3xn0F1XsExmXfhksx7Qxxvmgnw0mJf j8TNC+eTruIUgz0WF8dj =b+RO -----END PGP SIGNATURE----- --Sig_/I=gsP11Dn0r3HPglFlG2FlC-- --===============1464037985== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1464037985==--