From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 4/5] drm/i915: add destination color key support Date: Tue, 8 Nov 2011 14:40:43 -0800 Message-ID: <20111108144043.1e0c1258@jbarnes-desktop> References: <1320688976-10979-1-git-send-email-jbarnes@virtuousgeek.org> <1320688976-10979-5-git-send-email-jbarnes@virtuousgeek.org> <20111108220657.GD4754@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0793182637==" Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id 74A3EA0A4A for ; Tue, 8 Nov 2011 14:40:39 -0800 (PST) In-Reply-To: <20111108220657.GD4754@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rob.clark@linaro.org List-Id: intel-gfx@lists.freedesktop.org --===============0793182637== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/_+JaaaN8OvNLPZpVGo3iTyd"; protocol="application/pgp-signature" --Sig_/_+JaaaN8OvNLPZpVGo3iTyd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 8 Nov 2011 23:06:57 +0100 Daniel Vetter wrote: > On Mon, Nov 07, 2011 at 10:02:55AM -0800, Jesse Barnes wrote: > > Add new ioctls for getting and setting the current destination color > > key. This allows for simple overlay display control by matching a color > > key value in the primary plane before blending the overlay on top. > >=20 > > Signed-off-by: Jesse Barnes >=20 > A few comments below and a snide-y one here: If the goal is simply to keep > the bubble intact, this is fine by me. If we want something that has the > chance to be useable by a generic driver I think we want a drm interface > for plane/crtc properties (you could wire up set_gamma on planes in the > same series ... ;-) Again, I don't really care ... I'm ok with having generic properties for these. But I don't want to go through the same 8 month process of getting buy-in from other chipsets and people before the code is pushed as I've done with the core DRM bits. And since I know nothing of the color key support details for other chipsets, I've simply made this one device specific. We'll have more in the future too; current hardware can do source keying, and future hardware will be able to blend 3 planes per pipe together using alpha blending. If some other hardware has similar features and someone steps up to do the code, I'd be happy to work with them to get some generic interfaces in. In the meantime though, I'd like to see some i915 interfaces so we can actually use this stuff before the world ends in 2012. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/_+JaaaN8OvNLPZpVGo3iTyd Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOua/rAAoJEIEoDkX4Qk9hdYsP/1U2uL7yAI2KXmOG4pS2FSU5 hLnyIYFjJl6RF9598iqIh4NUwq+sk8VSJugOPi25EF9y/onfRLSXnZGHGe6AZcod 0XPxpMFB6zB5rhuzAGpd1s9Nt31KjLJI7vfCGoEQwKfaaMTZPrgfsP8doXLmSxKD qugUvg50GK1gSO+r5KWZO6P+hE+mdJM6ZyyQQ0Dyz4ZXQ2q2kcxg3TLxWja6wYeh fADfrI0rMIjLxsL3f3khzdPQuoQJsD56Qjb/+38HDXKX3Gyi8Y5thR9JITqfzwGj bQsXirnA6TpVyQgiZNDWOVa8ns6EWhu8QEX49J28IXAH9nbHP86X4/aqQQ8rnzqW U5bzRJZjAO//RFdfGzBiV9mW773gyjv+2Tf66hIAMT3588+uuq2gbqYFH+4lmyIE YlNK07oaHhNsuL56kH2P/7XSPkhsSzDVZFuCzse1H8G9WxGECzLCA4p5F5DIRy// Qztq/JLpuJKHd+JC3cqmQ/RXI0UE9MuF6pmlpIOSqPE/uWP+WmhnqhXyXC9t9exF +Xj6gYYf808vWi6cTyjcNk9P2nCI6NmF2CIbkvywWRiixfy12j2HoXIOxQsvkOYD gwhOIXBV2mW96CWl8dOhShG+2hVQ5gFJM07ahO5zmwXLQ//QaRor7p3xu+nXD2UG pVUdA5RsGpvIxwwQdlYZ =2lfJ -----END PGP SIGNATURE----- --Sig_/_+JaaaN8OvNLPZpVGo3iTyd-- --===============0793182637== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0793182637==--