From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support Date: Tue, 8 Nov 2011 23:16:19 +0100 Message-ID: <20111108221619.GF4754@phenom.ffwll.local> References: <1320688976-10979-1-git-send-email-jbarnes@virtuousgeek.org> <1320688976-10979-4-git-send-email-jbarnes@virtuousgeek.org> <20111108215703.GC4754@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20111108215703.GC4754@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, rob.clark@linaro.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 08, 2011 at 10:57:03PM +0100, Daniel Vetter wrote: > > + /* > > + * Clamp the width & height into the visible area. Note we don't > > + * try to scale the source if part of the visible region is offscreen. > > + * The caller must handle that by adjusting source offset and size. > > + */ > > Allowing the crtc dest rect to extend beyond that of the crtc and then refusing to > properly adjust tiling is a bit inconsistent. I call design-by-committee > on this one ;-) Oops, that comment went fubar while transferring from brainwaves to bits. Instead of "adjust tiling" it should be "adjust the source rectangle to the restricted crtc dest". -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48