From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and
 !intel-iommu
Date: Fri, 11 Nov 2011 15:24:16 +0100
Message-ID: <20111111142416.GK13213@amd.com>
References: <20111111134832.GI13213@amd.com>
 <1321019553.2027.47.camel@shinybook.infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <1321019553.2027.47.camel@shinybook.infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
To: David Woodhouse <dwmw2@infradead.org>
Cc: David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Nov 11, 2011 at 01:52:33PM +0000, David Woodhouse wrote:
> On Fri, 2011-11-11 at 14:48 +0100, Joerg Roedel wrote:
> > +#define intel_iommu_gfx_mapped 1=20
>=20
> That ought to be zero; if the IOMMU code isn't present, it's
> *definitely* not mapped through the IOMMU :)
>=20
> But I'm fairly sure this was already noticed and a patch is on its wa=
y
> upstream already.
>=20
> It's my fault =E2=80=94 my original testing patches to expose this in=
formation
> from the IOMMU code did put it into a header file, but when I sent it
> upstream I missed that part of the patch, thus leading to the horrid
> 'extern int intel_iommu_gfx_mapped;' in intel-gtt.c that your patch
> removes.

No problem, it was easy to fix :) I'll keep that patch in my out-of-tre=
e
branch until it is fixed upstream.


	Joerg

--=20
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr.=
 43632