From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamey Sharp Subject: Re: Glamor update Date: Fri, 11 Nov 2011 13:47:00 -0800 Message-ID: <20111111214700.GC3224@oh.minilop.net> References: <055401cca04d$db738a10$925a9e30$@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1550025797==" Return-path: In-Reply-To: <055401cca04d$db738a10$925a9e30$@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org Errors-To: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org To: Zhigang Gong Cc: intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org List-Id: intel-gfx@lists.freedesktop.org --===============1550025797== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+xNpyl7Qekk2NvDX" Content-Disposition: inline --+xNpyl7Qekk2NvDX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello! On Fri, Nov 11, 2011 at 04:42:32PM +0800, Zhigang Gong wrote: > During the last discussion about glamor=E2=80=99s plan in this list, we g= ot a > conclusion that to extract glamor from xorg and build a separate > glamor library to be used by any possible DDX driver. And Eric > suggested I can incrementally merge glamor into Intel video driver. > Now here is the update. >=20 > The separate glamor library is at : > git://people.freedesktop.org/~gongzg/glamor=EF=BC=8Cit provides two inter= faces: >=20 > 1. glamor : Rendering library. All the rendering functions are > implemented in this package.=20 >=20 > 2. glamor-egl : EGL support library. This package provides functions > to create and initialize OpenGL/EGL context. >=20 > There are a little bit more details to introduce glamor in the README fil= e. >=20 > The Intel video driver to merge glamor is at > git://people.freedesktop.org/~gongzg/xf86-video-intel=E2=80=99s =E2=80=9C= glamor=E2=80=9D branch. >=20 > I just started the merging stage. Only finished 3 patches to enable > glamor in UXA code path. Currently, only migrate fillspans and > polyfillrect to glamor. Will continue to migrate the rest functions. I've looked over all the source in your glamor repo, and your patches to the Intel driver. This work looks very promising! I'm eager to see more progress. I don't speak for the Intel graphics team or anything, but I noticed a couple minor things you might clean up. In the "glamor: turn on glamor." commit, there's a patch hunk that just adds an empty ifdef: - +#ifdef GLAMOR +#endif You might want to remove that. Also, the call to intel_glamor_create_textured_pixmap in intel_uxa_create_pixmap is inconsistently indented; it should just be tabs, looks like. Any chance you'll add some of the Xephyr/glamor functionality to xf86-video-nested, too? I think that should be easier to test and hack on. Jamey --+xNpyl7Qekk2NvDX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk69l9IACgkQp1aplQ4I9mWoVwCePDBObLtcuZbCLZyVGweeCSFc lwMAn2l1u1fRfrm+EaxvhSeNt19KAm61 =s/qJ -----END PGP SIGNATURE----- --+xNpyl7Qekk2NvDX-- --===============1550025797== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel --===============1550025797==--