From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/2] drm/i915: re-enable semaphores by default Date: Mon, 14 Nov 2011 13:23:43 -0800 Message-ID: <20111114132343.2ca2cdd9@jbarnes-desktop> References: <1321303155-12624-1-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1381587309==" Return-path: Received: from oproxy4-pub.bluehost.com (oproxy4-pub.bluehost.com [69.89.21.11]) by gabe.freedesktop.org (Postfix) with SMTP id AB2C49F071 for ; Mon, 14 Nov 2011 13:23:06 -0800 (PST) In-Reply-To: <1321303155-12624-1-git-send-email-eugeni.dodonov@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1381587309== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/8mCUzOfmEXsl4iknz.4B5VU"; protocol="application/pgp-signature" --Sig_/8mCUzOfmEXsl4iknz.4B5VU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 14 Nov 2011 18:39:14 -0200 Eugeni Dodonov wrote: > Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause > any known regressions as of now. >=20 > Let's re-enable them by default to provide a wider testing and coverage. >=20 > Acked-by: Keith Packard > CC: Jesse Barnes > CC: Daniel Vetter > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D42696 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D40564 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D41353 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D38862 > Signed-off-by: Eugeni Dodonov > --- > drivers/gpu/drm/i915/i915_drv.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_= drv.c > index cc531bb..71f887a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -58,10 +58,10 @@ module_param_named(powersave, i915_powersave, int, 06= 00); > MODULE_PARM_DESC(powersave, > "Enable powersavings, fbc, downclocking, etc. (default: true)"); > =20 > -unsigned int i915_semaphores __read_mostly =3D 0; > +unsigned int i915_semaphores __read_mostly =3D 1; > module_param_named(semaphores, i915_semaphores, int, 0600); > MODULE_PARM_DESC(semaphores, > - "Use semaphores for inter-ring sync (default: false)"); > + "Use semaphores for inter-ring sync (default: true)"); > =20 > unsigned int i915_enable_rc6 __read_mostly =3D 0; > module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600); I think we should keep them enabled; if one or two fat cats in the 1% still have issues we can debug those without bringing down performance for the other 99%. Acked-by: Jesse Barnes --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/8mCUzOfmEXsl4iknz.4B5VU Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOwYbfAAoJEIEoDkX4Qk9hGbUP/12MpufMteu+lf+kl8q/Jdye Y3olcRqe/cDXJapHNydPRqh3VUn/b6NyDz8A08in068YyczBXa5/6HXH28LHLNZz xNvxg4y4GsJv4+vydXhasht1FOCfAqbsI3cHVpR0AeRIZEUJBqL+3wIGYalhq+9L JwbUDrnGTx7mEVyke0EmP/ejzyGhVgsEicuVyqLMRtQVpNUnTwVGnGVVwquhC7jo g6XdkKdTslr0pEkYzQANNPL3HpGnu3IbDQ0g+96RmE0XODe9Ri7RXtLq+N4RZ1BM aBGO7/QQnXt5r0sFtxZW9KzPpNk6Jz1BoI6PsGxWaY4y+8XlPeyRVjcvc1WvUN/7 8cg0WPdfefMGK+w08SCs9B07KbzLNytaGArVZu/RWwuoF5+XDicXbe0jQD2F5Ciu pakL2RSEHWwTfTt0uL3uGqpIWhS9tG982jyWh3LuRbKH+B1k5XTGM2GNZovMyCct XYEs3lzFI9cv11f5/ceQtPMlkBWSBSUu7dk1KPqGFqXHL6gDizhq3tCj0CvRImAP gmWCNKLQFTrvp1L288PzY3XTen/Cs5D2HEKsr2HuDCkecVMCgCrUanUF0xWZTzd/ I2K8E+DVaUUB8QKnsMextWHDuLtAgyYODx6BivM3QdWmMGgByej5Vd+/EHmQl9qa AI88PRpfU0w83vQO7hVS =i0BV -----END PGP SIGNATURE----- --Sig_/8mCUzOfmEXsl4iknz.4B5VU-- --===============1381587309== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1381587309==--