From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/2] drm/i915: re-enable semaphores by default Date: Wed, 16 Nov 2011 11:23:50 -0800 Message-ID: <20111116112350.202a34bb@jbarnes-desktop> References: <1321303155-12624-1-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy3-pub.bluehost.com (oproxy3-pub.bluehost.com [69.89.21.8]) by gabe.freedesktop.org (Postfix) with SMTP id 20273A0CFD for ; Wed, 16 Nov 2011 11:23:03 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On Wed, 16 Nov 2011 17:05:37 -0200 Eugeni Dodonov wrote: > On Wed, Nov 16, 2011 at 15:24, Andrew Lutomirski wrote: > > > AFAICT my snb laptop has always been stable with semaphores and VT-d > > enabled. Is this problem possibly restricted to just desktop > > machines? I'm happy to test, since my box that can reproduce the hang > > instantly is still around. > > > > I cannot reproduce those issues on any mobile SNB, but I am out of desktop > ones. So perhaps it is a clue. > > Jesse, Keith, Daniel, what if we add something like: > > ... > .has_semaphores=1, .has_rc6=1 > ... > > to i915_drv.c intel_sandybridge_m_info, and take them into account when > using default values for those settings? Something like that is fine with me, or just doing it in modeset_init for certain chipsets. -- Jesse Barnes, Intel Open Source Technology Center