Re: [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled

Ben Widawsky
2011-11-17T01:14:04Z

On Wed, Nov 16, 2011 at 11:02:36PM -0200, Eugeni Dodonov wrote:
> On Wed, Nov 16, 2011 at 22:56, Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > This is not sufficient. You need to know that DMAR is compiled in, and
> > is actually being used.
> >
> > The variable you want is: !intel_iommu_gfx_mapped
> >
> > I think I saw Keith say he was sending this patch out on IRC.
> >
>
> Thanks, makes sense!
>
> I'll wait for Keith patch then to avoid duplicating work.
>
> On a side note, would it make sense to add the .enable_rc6 bits to
> i915_drv.c, in a similar way I did for semaphores?

I'm pretty sure we used to have that. In general, I dislike the idea of
device specific parameters until we know exactly why something doesn't
work. It makes it too tempting to just something off instead of
debugging it.
In your patch series I would have changed the check to be
if (GEN7)
do semaphore stuff
For the first patch, and then for the second patch
if (>= GEN6)
do semaphore stuff

Instead of changing the module parameter.

But that's just me, and others tend to disagree with me more than most.

Only bikeshedding because you asked :-).

Ben