Re: [PATCH 3/3] drm/i915: re-enable rc6 by default when GMAR is disabled

Ben Widawsky
2011-11-17T07:01:12Z

On Wed, 16 Nov 2011 22:11:06 -0800
keith.packard@intel.com wrote:

> On Wed, 16 Nov 2011 16:56:16 -0800, Ben Widawsky <ben@bwidawsk.net> wrote:
>
> > The variable you want is: !intel_iommu_gfx_mapped
>
> From what Daniel Vetter said:
>
> > Last time I've played around with all the combinations, only
> > intel_iommu=off was good enough to prevent the hang.
> > intel_iommu=igd_off still hangs (which is what the current value
> > exported by the dmar code dopends on, iirc). If I remember things
> > correctly, intel_iommu=off also reliably works around issues for all
> > reporters (both semaphores and rc6).
>
> we need to use dmar_disabled instead of intel_iommu_gfx_mapped. Other
> places in the code use:
>
> if (no_iommu || dmar_disabled)
>

As long as he meant igfx_off, then okay... igd_off didn't immediately register
to me earlier. Sorry for the confusion.