Re: [PATCH 1/3] drm/i915: support for per-device semaphores settings

Daniel Vetter
2011-11-17T09:30:31Z

On Thu, Nov 17, 2011 at 01:17, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> This allows to enable semaphores by default on devices which support them.
>
> By default, let's enable them on IVB only for now. When DMAR issues on SNB
> will be solved, we can enable them on SNB as well.
>
> For IVB, it should fix many hangs and issues.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Minor bikeshed comment: I prefer an if chain instead of overloading
intel_info - currently intel_info contains information about the hw
and work-arounds are applied in the code. This way they also stick out
more. I'll try to test this as soon as I get back home.
-Daniel
--
Daniel Vetter
daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch