From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Handle unmappable buffers during error state capture Date: Tue, 29 Nov 2011 20:16:56 +0100 Message-ID: <20111129191656.GF11090@phenom.ffwll.local> References: <20111129110526.GA3989@phenom.ffwll.local> <1322593326-6764-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 14D519E7B2 for ; Tue, 29 Nov 2011 11:15:33 -0800 (PST) Received: by eaac10 with SMTP id c10so4157359eaa.36 for ; Tue, 29 Nov 2011 11:15:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <1322593326-6764-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 29, 2011 at 07:02:06PM +0000, Chris Wilson wrote: > As the buffer is not necessarily accessible through the GTT at the time > of a GPU hang, and capturing some of its contents is far more valuable > than skipping it, provide a clflushed fallback read path. We still > prefer to read through the GTT as that is more consistent with the GPU > access of the same buffer. So example it will demonstrate any errorneous > tiling or swizzling of the command buffer as seen by the GPU. > > This becomes necessary with use of CPU relocations and lazy GTT binding, > but could potentially happen anyway as a result of a pathological error. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48