From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/11] drm/i915: initialization/teardown for the aliasing ppgtt Date: Wed, 30 Nov 2011 10:55:01 +0100 Message-ID: <20111130095501.GE3823@phenom.ffwll.local> References: <1322512539-3923-1-git-send-email-daniel.vetter@ffwll.ch> <1322512539-3923-4-git-send-email-daniel.vetter@ffwll.ch> <20111129234923.GD25081@seagal.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B36B9E7E9 for ; Wed, 30 Nov 2011 01:53:39 -0800 (PST) Received: by eaac10 with SMTP id c10so519189eaa.36 for ; Wed, 30 Nov 2011 01:53:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20111129234923.GD25081@seagal.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 29, 2011 at 03:49:23PM -0800, Ben Widawsky wrote: > On Mon, Nov 28, 2011 at 09:35:30PM +0100, Daniel Vetter wrote: > > This just adds the setup and teardown code for the ppgtt PDE and the > > last-level pagetables, which are fixed for the entire lifetime, at > > least for the moment. > > > > v2: Kill the stray debug printk noted by and improve the pte > > definitions as suggested by Chris Wilson. > > > > Signed-Off-by: Daniel Vetter > --- > {...} > > > > +#define I915_PPGTT_PD_ENTRIES 512 > > +#define I915_PPGTT_PT_ENTRIES 1024 > Not to fond that we have this redefined as GEN6_PTES_PER_PD (which makes > more sense as far as naming goes IMO) I've killed the redundant define. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48