From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: Is MI_FLUSH_ENABLE bit 12? Date: Tue, 6 Dec 2011 12:21:02 -0800 Message-ID: <20111206122102.33ef6b44@jbarnes-desktop> References: <861usr63vf.fsf@sumi.keithp.com> <87zkfephaa.fsf@eliezer.anholt.net> <20111130034200.GA7069@cloud01> <87ipm1cm3c.fsf@eliezer.anholt.net> <20111205145709.5a12cee4@jbarnes-desktop> <87k469iieg.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1359780311==" Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 68A7E9F398 for ; Tue, 6 Dec 2011 12:21:08 -0800 (PST) In-Reply-To: <87k469iieg.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: Ben Widawsky , "drivers, Intel" List-Id: intel-gfx@lists.freedesktop.org --===============1359780311== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/J4ISBrQb35h938=+1KSl2I8"; protocol="application/pgp-signature" --Sig_/J4ISBrQb35h938=+1KSl2I8 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 06 Dec 2011 11:56:07 -0800 Eric Anholt wrote: > > It's one of those "been there forever" bits. A comment wouldn't hurt, > > but we should also put in a doc change request (in fact I think I did > > that but it went into a black hole). >=20 > Well, by "been there forever", you mean "introduced in: >=20 > commit a69ffdbfcba8eabf2ca9d384b578e6f28b339c61 > Author: Zhenyu Wang > Date: Mon Aug 30 16:12:42 2010 +0800 >=20 > drm/i915: Enable MI_FLUSH on Sandybridge > =20 > MI_FLUSH is being deprecated, but still available on Sandybridge. > Make sure it's enabled as userspace still uses MI_FLUSH. > =20 > Signed-off-by: Zhenyu Wang > Cc: stable@kernel.org > Signed-off-by: Chris Wilson " >=20 > It should be removed on Ironlake, and fixed to be 12 on SNB or just > removed. No, "fixed to be 12" would just encourage people to still try it and break their machines. We can safely remove it now that we don't use it anywhere. And we can fix the docs so that if people do want to mess with it they won't try bit 12. --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/J4ISBrQb35h938=+1KSl2I8 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJO3nkuAAoJEIEoDkX4Qk9hQCsP+weAQHPmZCJ9HLsv5g2ZA8QA NvAsz0yQv1u2+JPh54Vu+UoF1GtEJAQybzB0H9ub/kK2748CXKVNESz2hKBjeKOo vLkjefLHmNKwgCoke7WM+Bu6J/N1P8v2pk700+gSWV5LdHCluPbFWGc6HttiNMVl +HgKpWzyZ8OzyL89SkmKvK+gRYmF9aGvB/mjRqIoFcR5r4uMHIK1ELAT9WJv8Zw0 bAyp5aquzXAbgbDwwpGvPUqFlq5N4uxSRusRw34PEyAN63iFIobv9lIC01R+1Hx5 C54NdBsx4yB0+8pspnj/a8IVTua4ZKOLaBF9a2ozRGW0xZ/AehQGXyeJf/aW0eA7 bCbGtv6n0ycBCdF3g+Y+2NxNGE1VWDqwFb9GPA/GIAvjDj36HegAPTET6ZUzTS0m uml9PYPb0JWt285jP4rgW4ulZJitZT5rDYNxUEmgSCbyGyF2z5BwO80a+CItapeC 96/kfboMNWXOYKeFV67+WWhBKG70luB/yJp7bRXqH0du4pzB/cFmc5aZt3b1p0W7 nYWYojUzUsj240s0ttPJ4JkmAVCG54dczDnPvZmPGpZWNYoJUS4Kli7OR2IoF7yr MdcL39o+nktv6byi32VvvJqUi4FLRRRyuwKZ4bo0V3EWVM1yuhXVm86weDb/U/We dp55nrqntIU8c5MidoGT =8Rmt -----END PGP SIGNATURE----- --Sig_/J4ISBrQb35h938=+1KSl2I8-- --===============1359780311== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1359780311==--