From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: Plane support for SNB and IVB Date: Mon, 12 Dec 2011 22:21:43 +0100 Message-ID: <20111212212113.GB5773@phenom.ffwll.local> References: <1323289763-1963-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BF0D9E81A for ; Mon, 12 Dec 2011 13:20:09 -0800 (PST) Received: by fabs1 with SMTP id s1so2263312fab.36 for ; Mon, 12 Dec 2011 13:20:08 -0800 (PST) Content-Disposition: inline In-Reply-To: <1323289763-1963-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Dec 07, 2011 at 12:29:20PM -0800, Jesse Barnes wrote: > I think the core support is ready now, but I'd like feedback on the > color key ioctl. It would be good to have a way to disable it at > runtime (w/o color keying enabled, the sprite will always sit on top of > the primary), and potentially add alpha support at some point. > > Would 0 as the color key work well enough as a "disable" flag? Or > should I add a separate field to the ioctl? Anyone have a preference? 0 is black and I can image a legit color key with "black bars". Any other value makes the interface kinda ad-hoc. So a separate field preferred. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48