From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v5 Date: Mon, 12 Dec 2011 22:56:34 +0100 Message-ID: <20111212215634.GB6832@phenom.ffwll.local> References: <1323289763-1963-1-git-send-email-jbarnes@virtuousgeek.org> <1323289763-1963-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id DF9C29E709 for ; Mon, 12 Dec 2011 13:54:59 -0800 (PST) Received: by wgbds11 with SMTP id ds11so9850121wgb.12 for ; Mon, 12 Dec 2011 13:54:59 -0800 (PST) Content-Disposition: inline In-Reply-To: <1323289763-1963-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Dec 07, 2011 at 12:29:21PM -0800, Jesse Barnes wrote: > The video sprites support various video surface formats natively and can > handle scaling as well. So add support for them using the new DRM core > sprite support functions. > > v2: use drm specific fourcc header and defines > v3: address Daniel's comments: > - don't take struct mutex around register access (only needed for > regs in the GT power well) > - don't hold struct mutex across vblank waits > - fix up update_plane API (pass obj instead of GTT offset) > - add interlaced defines for sprite regs > - drop unnecessary 'reg' variables > - comment double buffered reg flushing > Also fix w/h confusion when writing the scaling reg. > v4: more fixes, address more comments from Daniel, and include Hai's fix > - prevent divide by zero in scaling calculation (Hai Lan) > - update to Ville's new DRM_FORMAT_* types > - fix sprite watermark handling (calc based on CRTC size, separate > from normal display wm) > - remove private refcounts now that the fb cleanups handles things > v5: add linear surface support > > For this version, I tested DPMS since it came up in the last review; > DPMS off/on works ok when a video player is working under X, but for > power saving we'll probably want to do something smarter. I'll leave > that for a separate patch on top. Likewise with the refcounting/fb > layer handling, which are really separate cleanups. > > Signed-off-by: Jesse Barnes I didn't bother to recheck the regs and and the wm stuff looks like the usual magic ;-) Otherwise you've implemented way more of my review comments than I could possibly still remember, so it must be good. Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48