From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/3] drm/i915: track sprite coverage and disable primary plane if possible Date: Mon, 12 Dec 2011 23:17:28 +0100 Message-ID: <20111212221728.GD6832@phenom.ffwll.local> References: <1323289763-1963-1-git-send-email-jbarnes@virtuousgeek.org> <1323289763-1963-4-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E7119E81E for ; Mon, 12 Dec 2011 14:15:53 -0800 (PST) Received: by fabs1 with SMTP id s1so2319915fab.36 for ; Mon, 12 Dec 2011 14:15:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1323289763-1963-4-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Dec 07, 2011 at 12:29:23PM -0800, Jesse Barnes wrote: > To save power when the sprite is full screen, we can disable the primary > plane on the same pipe. Track the sprite status and enable/disable the > primary opportunistically. > > v2: remove primary plane enable/disable hooks; they're identical > > Signed-off-by: Jesse Barnes Minor nitpick on patch-splitting: You've left the disable_primary calculations in the 1st patch. But since I didn't notice it there, I can't be that bad ;-) Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48