From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v5 Date: Tue, 13 Dec 2011 11:46:29 -0800 Message-ID: <20111213114629.5f899799@jbarnes-desktop> References: <1323289763-1963-1-git-send-email-jbarnes@virtuousgeek.org> <1323289763-1963-2-git-send-email-jbarnes@virtuousgeek.org> <20111212215634.GB6832@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2051818319==" Return-path: Received: from oproxy5-pub.bluehost.com (oproxy5-pub.bluehost.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id AEFF09EF3B for ; Tue, 13 Dec 2011 11:46:33 -0800 (PST) In-Reply-To: <20111212215634.GB6832@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2051818319== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/18V=ORiOy7A8W6oJ4dQQSlv"; protocol="application/pgp-signature" --Sig_/18V=ORiOy7A8W6oJ4dQQSlv Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 12 Dec 2011 22:56:34 +0100 Daniel Vetter wrote: > On Wed, Dec 07, 2011 at 12:29:21PM -0800, Jesse Barnes wrote: > > The video sprites support various video surface formats natively and can > > handle scaling as well. So add support for them using the new DRM core > > sprite support functions. > >=20 > > v2: use drm specific fourcc header and defines > > v3: address Daniel's comments: > > - don't take struct mutex around register access (only needed for > > regs in the GT power well) > > - don't hold struct mutex across vblank waits > > - fix up update_plane API (pass obj instead of GTT offset) > > - add interlaced defines for sprite regs > > - drop unnecessary 'reg' variables > > - comment double buffered reg flushing > > Also fix w/h confusion when writing the scaling reg. > > v4: more fixes, address more comments from Daniel, and include Hai's fix > > - prevent divide by zero in scaling calculation (Hai Lan) > > - update to Ville's new DRM_FORMAT_* types > > - fix sprite watermark handling (calc based on CRTC size, separate > > from normal display wm) > > - remove private refcounts now that the fb cleanups handles things > > v5: add linear surface support > >=20 > > For this version, I tested DPMS since it came up in the last review; > > DPMS off/on works ok when a video player is working under X, but for > > power saving we'll probably want to do something smarter. I'll leave > > that for a separate patch on top. Likewise with the refcounting/fb > > layer handling, which are really separate cleanups. > >=20 > > Signed-off-by: Jesse Barnes >=20 > I didn't bother to recheck the regs and and the wm stuff looks like the > usual magic ;-) Otherwise you've implemented way more of my review > comments than I could possibly still remember, so it must be good. >=20 > Reviewed-by: Daniel Vetter The one thing I kept out was the "disable planes in generic code" call. The TI guys are working on using planes to represent all planes, not just additional overlays, so calling disable from generic code seemed unfriendly. Keith, this one is ready for -next. I'll clean up the ioctl now and re-post; without it the overlays will always sit on top without blending, so the patch is still safe. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/18V=ORiOy7A8W6oJ4dQQSlv Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJO56uVAAoJEIEoDkX4Qk9hwRoP/A223ii9HAdSeEA5YeoNiGIb IjDiHyAG6LWkYodcWnBxGht1SdzmycA1o1GFXoaZo/GkFoVB0C7ATDSfVp4w0gTd aiJM87ASujZ8fNCR6klC55laV8mljk9R7+J2x4l+Oh1Ee1aTuzHIlITEYi/EGj9u QkgcMHknWB9zWPVcwn/DcEasVNY41aq0DgaWchI2R66Pylx1W3Msejl7AipnAtJD 1IgB5XI7WVOnbeHFVuWLFecxUR5LzdUiIERpXLA5+fEmB63hbvomT32FemHIx5+S 6M5ijQOi8u6y38eIXNp/FwZGQndOPjY8gHkOFShBh2xxCgtI4y80lmz8VjRX0Whh 4bZpBF02M2uilIzRar/Q/a672IeBJB/I/AvBkXNEboMOml9o45mTQrQ8/PMWXmyx lAPnSUWQycDokCAapfItuX8FCBbFFrhN4kwQ5sjWN1CltbCjZEJqxc6anwuG78xy LeiowHEHIQFYa9LNFKynY5o3UHHoVgsQV6EjBl9YZ6mj7jN5CszCuElpbdeoa/Dg zHvXJuEWi/z75IVntTWMpomllt6aiTH+vsp3wmaNvsu+w3Gdzt/9QgusT1mrtmW5 Xej3k+JQ398rOaDu+gZKEDdwBO7MZCKgRzAsJxgAtNZ/oEGgTK2+878dNOKu7oh5 YYaycYQfslZOqEqi1Tbp =98Ir -----END PGP SIGNATURE----- --Sig_/18V=ORiOy7A8W6oJ4dQQSlv-- --===============2051818319== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2051818319==--