From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 1/3] drm/i915: add SNB and IVB video sprite support v5 Date: Tue, 13 Dec 2011 13:11:39 -0800 Message-ID: <20111213131139.40a68d1c@jbarnes-desktop> References: <1323289763-1963-1-git-send-email-jbarnes@virtuousgeek.org> <1323289763-1963-2-git-send-email-jbarnes@virtuousgeek.org> <20111212215634.GB6832@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1353660617==" Return-path: Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6]) by gabe.freedesktop.org (Postfix) with SMTP id D1517A08A0 for ; Tue, 13 Dec 2011 13:11:45 -0800 (PST) In-Reply-To: <20111212215634.GB6832@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1353660617== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/n.10iT_xlwCD9nOAbzRG0x_"; protocol="application/pgp-signature" --Sig_/n.10iT_xlwCD9nOAbzRG0x_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 12 Dec 2011 22:56:34 +0100 Daniel Vetter wrote: > On Wed, Dec 07, 2011 at 12:29:21PM -0800, Jesse Barnes wrote: > > The video sprites support various video surface formats natively and can > > handle scaling as well. So add support for them using the new DRM core > > sprite support functions. > >=20 > > v2: use drm specific fourcc header and defines > > v3: address Daniel's comments: > > - don't take struct mutex around register access (only needed for > > regs in the GT power well) > > - don't hold struct mutex across vblank waits > > - fix up update_plane API (pass obj instead of GTT offset) > > - add interlaced defines for sprite regs > > - drop unnecessary 'reg' variables > > - comment double buffered reg flushing > > Also fix w/h confusion when writing the scaling reg. > > v4: more fixes, address more comments from Daniel, and include Hai's fix > > - prevent divide by zero in scaling calculation (Hai Lan) > > - update to Ville's new DRM_FORMAT_* types > > - fix sprite watermark handling (calc based on CRTC size, separate > > from normal display wm) > > - remove private refcounts now that the fb cleanups handles things > > v5: add linear surface support > >=20 > > For this version, I tested DPMS since it came up in the last review; > > DPMS off/on works ok when a video player is working under X, but for > > power saving we'll probably want to do something smarter. I'll leave > > that for a separate patch on top. Likewise with the refcounting/fb > > layer handling, which are really separate cleanups. > >=20 > > Signed-off-by: Jesse Barnes >=20 > I didn't bother to recheck the regs and and the wm stuff looks like the > usual magic ;-) Otherwise you've implemented way more of my review > comments than I could possibly still remember, so it must be good. >=20 > Reviewed-by: Daniel Vetter I take it back, I need to re-post this one minus a few lines now that I'm updating the color key support. New series on its way. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/n.10iT_xlwCD9nOAbzRG0x_ Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJO57+LAAoJEIEoDkX4Qk9hUJcQAKigijdGhRNbrtWBmAy5e5R7 fyz1dhdvHehdZ9Vc0EoRjCiG+gNmkgfGkbPczwHnUDamdbMWQRAWoi4ch09A+jPV Rudk919x5ORuI0Gfb3cWq6FHKXkjWkGs4aUWXz2vX+1h/bcAq0YyPBuR3GhA5r9h itubMwEGUpV1XUY/K28Mv4coRuetzPqqgCpsITclnj44uIXGH6DH5qYu0h4OfvOd vsfbSQVt4KzbS8CG0g2MC6DkrnLC/aTZryBkRzmGFldMDQcPO0MCRin9plRhbL7u Aay2+0HQzS2J66YHaIY3v81PkOUwrUR0Z4Yq30cZUXW8DC3X5B1JFFBNDdauot6S BSbNBSu4ZWBdKQ9lXqICMiL/KnVLq81H9567BWJKac+OJjIRF88Ys2Cm6Q6q8tG4 M+I9D3J7kC90s/UIfmLsO7klcrHF0O4fBii/Zbhcj/VKXBGsmstnxXQy+i/S/ZHX ABNVzHIT5TKgV/nJGDy9lJ8nM1QMzZoGG9mZXyLeWevn93R4BQlelzafX2gMDydE XcmjqRBGyLKupSArCZnFIyjCiG4yZc1HmbIhntWsF/gyQYHWKvsv+NSnT0EwUMnR I8upVSUCv/NxwVW2hlI97HJ6GPAUbjeDDvQS5G9xvVSZEbQ24Cy1SfGK46p9E8dH uKsxH7fcdk830M4xNPWU =q0iZ -----END PGP SIGNATURE----- --Sig_/n.10iT_xlwCD9nOAbzRG0x_-- --===============1353660617== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1353660617==--