From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: add a LLC feature flag in device
 description
Date: Tue, 13 Dec 2011 17:09:37 +0100
Message-ID: <20111213160937.GB4125@phenom.ffwll.local>
References: <e0d58a$2ifdfl@orsmga002.jf.intel.com>
	<1323781515-6237-1-git-send-email-eugeni@dodonov.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com
	[209.85.161.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5D37B9E7FA
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Dec 2011 08:08:01 -0800 (PST)
Received: by fabs1 with SMTP id s1so382184fab.36
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 13 Dec 2011 08:08:00 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1323781515-6237-1-git-send-email-eugeni@dodonov.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni@dodonov.net>
Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov <eugeni.dodonov@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Dec 13, 2011 at 11:05:15AM -0200, Eugeni Dodonov wrote:
> From: Eugeni Dodonov <eugeni.dodonov@intel.com>
> 
> LLC is not SNB-specific, so we should check for it in a more generic way.
> 
> v2: export LLC support status via debugfs and DRM GETPARAM.
> 
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Nice patch and would get an r-b from me safe for the new GETPARAM. I
really think we need to export this on a per-bo basis (and with the caveat
that the kernel is free to change the caching on every ioctl that uses
it). I.e. without forcing userspace to check the caching bits before any
bo access I fear that we won't be able to change the kernel's behaviour in
this area, which surely results in backwards-compat hell when the first
w/a that needs such changes comes around. Hence in its current from

Nacked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

So please drop the GETPARAM. For the per-bo get_cache_flags ioctl there's
already a patch by Ben floating around.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48