From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: add color key support v4 Date: Wed, 14 Dec 2011 00:00:11 +0100 Message-ID: <20111213230011.GB18675@phenom.ffwll.local> References: <1323811180-17581-1-git-send-email-jbarnes@virtuousgeek.org> <1323811180-17581-3-git-send-email-jbarnes@virtuousgeek.org> <20111213140911.2cba6c96@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 3FE1FA08FC for ; Tue, 13 Dec 2011 14:58:35 -0800 (PST) Received: by fabs1 with SMTP id s1so979790fab.36 for ; Tue, 13 Dec 2011 14:58:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <20111213140911.2cba6c96@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Dec 13, 2011 at 02:09:11PM -0800, Jesse Barnes wrote: > Add new ioctls for getting and setting the current destination color > key. This allows for simple overlay display control by matching a color > key value in the primary plane before blending the overlay on top. > > v2: remove unnecessary mutex acquire/release around reg accesses > v3: add support for full color key management > v4: fix copy & paste bug in snb_get_colorkey > don't bother checking min/max values against docs as the docs are likely > wrong (how could we handle 10bpc surface formats?) With the changes in v4 I can actually slap an r-b onto this and fix up Jesse's a bit over-eager use of that tag ;-) Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48