From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: Moving intel_decode.c to libdrm Date: Wed, 21 Dec 2011 19:46:24 +0100 Message-ID: <20111221184624.GD3827@phenom.ffwll.local> References: <1324490983-6975-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id E13389E769 for ; Wed, 21 Dec 2011 10:44:39 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so12208494wgb.0 for ; Wed, 21 Dec 2011 10:44:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <1324490983-6975-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Dec 21, 2011 at 10:09:30AM -0800, Eric Anholt wrote: > I was once again embarassed while explaining to either Ken or Paul > about how we handle reusing the intel_decode.c file in two trees. > Here's my attempt at a solution to the problem: Move the code into > libdrm, and try to give it an API that we won't have to continually > rev as we throw the kitchen sink into the intel_decode() function > arguments. > > One of the things I'm interested in is doing a version that directly > pokes at BOs instead of just a pointer, which would let us decode > associated blocks as we see the various state pointers to them. > There's also room for some interesting validation in that case. > > Further patches (mostly fixing up style) are in my libdrm tree on the > intel-decode branch. I've tested it with Mesa on gen7 (I have further > code to land to make gen7 decode more reasonable). I've only done a high-level cruise review of this series, but this is awesome (and has been sitting on my todo list for way to long). Very-Much-Acked-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48